macos bug

.github/workflows/release.yml

@@ -0,0 +1,22 @@
+name: Main
+
+on:
+  push:
+    branches:
+      - main
+
+jobs:
+  build:
+    runs-on: macos-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - uses: actions/setup-node@v2
+        with:
+          node-version: '14'
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+      - name: Build
+        run: yarn run dist
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

README.md

@@ -14,6 +14,24 @@ To combat and alleviate the symptoms there is the famous 20/20/20 rule that aims
 
 This is not medical advice. Read more [here](https://en.wikipedia.org/wiki/Computer_vision_syndrome) and [here](https://www.aoa.org/healthy-eyes/eye-and-vision-conditions/computer-vision-syndrome).
 
-## 📦 Install
+## 📦 Installation
 
 Head to the [release page](https://github.com/cupcakearmy/unpixel/releases) and grab the latest for your platform.
+
+- For `macOS` you can downlaod the `.dmg` image.
+- For `Windows` download the `.exe`.
+- For `Linux` either the `.AppImage` or `.deb`, you will know what fits you 😉.
+
+## Building / Development
+
+1. Clone the repo
+2. `yarn install`
+3. `yarn dist` to build for all platforms
+
+Alternatevly you can run `yarn build` and the `yarn electron-builder -m` for `macOS`, `-l` fir `linux` or `-w` for `windows`.
+
+## RELEASE
+
+1. Create a draft release with the new version. (e.g. tag with `v1.2.3`).
+2. Push to master and github workflow will build and upload assets to the draft matching the version of `package.json` and draft.
+3. When ready publish release.

electron-builder.yml

@@ -1,14 +1,18 @@
 appId: "io.nicco.app.unpixel"
-# productName: "UnPixel"
 files:
   - assets
   - dist
 directories:
   output: "./out"
 mac:
-  target: "dmg"
+  target:
+    - dmg
   identity: null
 win:
-  target: "nsis"
+  target: 
+    - nsis
 linux:
   category: "Utility"
+  target:
+    - AppImage
+    - deb

package.json

@@ -11,7 +11,7 @@
   "repository": {
     "url": "https://github.com/cupcakearmy/unpixel"
   },
-  "version": "1.0.2",
+  "version": "1.0.5",
   "main": "./dist/back/index.js",
   "scripts": {
     "start": "electron .",
@@ -22,7 +22,6 @@
     "build:back": "parcel build --target back ./src/back/index.ts",
     "build": "run-s build:*",
     "pack": "electron-builder -mwl",
-    "pack:dev": "electron-builder -m",
     "dist": "rm -rf .parcel-cache dist && run-s build pack"
   },
   "browserslist": [
@@ -56,6 +55,7 @@
     "@types/auto-launch": "^5.0.1",
     "@types/react": "^17.0.3",
     "@types/react-dom": "^17.0.3",
+    "@types/semver": "^7.3.4",
     "electron": "^12.0.0",
     "electron-builder": "^22.10.5",
     "npm-run-all": "^4.1.5",

src/back/banner.ts

@@ -49,7 +49,8 @@ export default class Banner {
       },
       width: 1200,
       height: 600,
-      fullscreen: !DEV,
+      fullscreen: true,
+      simpleFullscreen: os.platform() === 'darwin',
     }
     this.window = new BrowserWindow(options)
 
@@ -59,17 +60,6 @@ export default class Banner {
     if (DEV) {
       this.window.webContents.toggleDevTools()
     } else {
-      switch (os.platform()) {
-        case 'win32':
-          break
-        case 'linux':
-          break
-        case 'darwin':
-          this.window.setSimpleFullScreen(true)
-          this.window.setFullScreenable(false)
-          break
-      }
-      // this.window.maximize()
       this.window.setAlwaysOnTop(true, 'floating', 99)
       this.window.setVisibleOnAllWorkspaces(true, { visibleOnFullScreen: true })
       this.window.setMovable(false)

src/back/tray.ts

@@ -30,7 +30,7 @@ export default class TrayUtility {
 
   static setStatus(status: string) {
     this.menu[0].label = status
-    this.tray.setContextMenu(this.build())
+    this.tray?.setContextMenu(this.build())
   }
 
   private static build() {

src/back/updater.ts

@@ -7,7 +7,7 @@ import pkg from '../../package.json'
 
 const current = semver.coerce(pkg.version)
 const url = 'https://api.github.com/repos/cupcakearmy/unpixel/tags'
-const interval = 1000 * 60 * 60 * 10 // 10 Minutes
+const interval = 1000 * 60 * 15 // 10 Minutes
 
 export default class Updater {
   static init() {
@@ -20,8 +20,9 @@ export default class Updater {
       url,
     })
     // parse tags and reverse sort them to get the highest
-    const tags = data.map((d) => semver.coerce(d.name)).sort(semver.rcompare)
+    const tags = data.map((d: any) => semver.coerce(d.name)).sort(semver.rcompare)
     const latest = tags[0]
+    if (!current) throw new Error('Could not determine current version')
     if (semver.lt(current, latest)) {
       logger.info('New version available')
       dialog

src/front/banner/index.tsx

@@ -7,15 +7,17 @@ import { render } from 'react-dom'
 // @ts-ignore
 import chime from 'url:../assets/chime.mp3'
 
-const useKeyPress = (handler) => {
-  const handlerRef = useRef<(e: KeyboardEvent) => void>()
+const useKeyPress = (handler: (e: KeyboardEvent) => void) => {
+  const handlerRef = useRef<typeof handler>()
 
   useEffect(() => {
     handlerRef.current = handler
   }, [handler])
 
   useEffect(() => {
-    const fn = (event) => handlerRef.current(event)
+    const fn = (event: KeyboardEvent) => {
+      if (handlerRef.current) handlerRef.current(event)
+    }
     window.addEventListener('keydown', fn)
     return () => {
       window.removeEventListener('keydown', fn)

src/front/base.css

@@ -1,4 +1,3 @@
-/* @import 'hiq/dist/hiq.css'; */
 @import 'spectre.css/dist/spectre.min.css';
 @import 'tachyons/css/tachyons.min.css';
 

src/front/settings/About.tsx

@@ -1,4 +1,4 @@
-import React, { useCallback } from 'react'
+import React from 'react'
 
 import Link from './ExternalLink'
 

src/front/settings/Footer.tsx

@@ -9,7 +9,7 @@ const Footer: React.FC = () => {
       <div className="flex justify-center items-center">
         <Link link="https://github.com/cupcakearmy" text="Github" />
         <div className="ph1"> - </div>
-        <Link link="https://nicco.io/support" text="Support" />
+        <Link link="https://nicco.io/support" text="Support / Donate" />
       </div>
       <div className="code o-20 mt1">
         <small>version: {version}</small>

tsconfig.json

@@ -9,7 +9,7 @@
     // "lib": [],                                   /* Specify library files to be included in the compilation. */
     // "allowJs": true,                             /* Allow javascript files to be compiled. */
     // "checkJs": true,                             /* Report errors in .js files. */
-    // "jsx": "preserve",                           /* Specify JSX code generation: 'preserve', 'react-native', 'react', 'react-jsx' or 'react-jsxdev'. */
+    "jsx": "react" /* Specify JSX code generation: 'preserve', 'react-native', 'react', 'react-jsx' or 'react-jsxdev'. */,
     // "declaration": true,                         /* Generates corresponding '.d.ts' file. */
     // "declarationMap": true,                      /* Generates a sourcemap for each corresponding '.d.ts' file. */
     // "sourceMap": true,                           /* Generates corresponding '.map' file. */

yarn.lock

@@ -1665,6 +1665,11 @@
   resolved "https://registry.yarnpkg.com/@types/scheduler/-/scheduler-0.16.1.tgz#18845205e86ff0038517aab7a18a62a6b9f71275"
   integrity sha512-EaCxbanVeyxDRTQBkdLb3Bvl/HK7PBK6UJjsSixB0iHKoWxE5uu2Q/DgtpOhPIojN0Zl1whvOd7PoHs2P0s5eA==
 
+"@types/semver@^7.3.4":
+  version "7.3.4"
+  resolved "https://registry.yarnpkg.com/@types/semver/-/semver-7.3.4.tgz#43d7168fec6fa0988bb1a513a697b29296721afb"
+  integrity sha512-+nVsLKlcUCeMzD2ufHEYuJ9a2ovstb6Dp52A5VsoKxDXgvE051XgHI/33I1EymwkRGQkwnA0LkhnUzituGs4EQ==
+
 "@types/verror@^1.10.3":
   version "1.10.4"
   resolved "https://registry.yarnpkg.com/@types/verror/-/verror-1.10.4.tgz#805c0612b3a0c124cf99f517364142946b74ba3b"