From 9b5023edbf56529d62bca7b88b439a8df6516979 Mon Sep 17 00:00:00 2001
From: Christian Kaisermann <christian@kaisermann.me>
Date: Mon, 15 Feb 2021 13:32:20 -0300
Subject: [PATCH] =?UTF-8?q?test:=20=F0=9F=92=8D=20add=20tests=20for=20inva?=
 =?UTF-8?q?lid=20ICU=20syntax?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/runtime/stores/formatters.ts       | 10 ++++----
 test/fixtures/en.json                  |  3 ++-
 test/runtime/stores/formatters.test.ts | 33 ++++++++++++++++++--------
 3 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/src/runtime/stores/formatters.ts b/src/runtime/stores/formatters.ts
index 4108ee3..55957f2 100644
--- a/src/runtime/stores/formatters.ts
+++ b/src/runtime/stores/formatters.ts
@@ -72,10 +72,7 @@ const formatMessage: MessageFormatter = (id, options = {}) => {
   try {
     result = getMessageFormatter(message, locale).format(values) as string;
   } catch (e) {
-    console.warn(
-      `[svelte-i18n] Message with "${id}" has syntax error:`,
-      e.message,
-    );
+    console.warn(`[svelte-i18n] Message "${id}" has syntax error:`, e.message);
   }
 
   return result;
@@ -93,7 +90,10 @@ const formatNumber: NumberFormatter = (n, options) => {
   return getNumberFormatter(options).format(n);
 };
 
-const getJSON: JSONGetter = <T = any>(id: string, locale = getCurrentLocale()) => {
+const getJSON: JSONGetter = <T = any>(
+  id: string,
+  locale = getCurrentLocale(),
+) => {
   return lookup(id, locale) as T;
 };
 
diff --git a/test/fixtures/en.json b/test/fixtures/en.json
index 62186de..c42357f 100644
--- a/test/fixtures/en.json
+++ b/test/fixtures/en.json
@@ -5,5 +5,6 @@
   },
   "photos": "You have {n, plural, =0 {no photos.} =1 {one photo.} other {# photos.}}",
   "title": "Page title",
-  "sneakers": "sneakers"
+  "sneakers": "sneakers",
+  "with-syntax-error": "Hello {{name}}!"
 }
diff --git a/test/runtime/stores/formatters.test.ts b/test/runtime/stores/formatters.test.ts
index d21adb9..7dfbfb2 100644
--- a/test/runtime/stores/formatters.test.ts
+++ b/test/runtime/stores/formatters.test.ts
@@ -106,30 +106,43 @@ describe('format message', () => {
   });
 
   it('errors out when value found is not string', () => {
-    const { warn } = global.console;
-
-    jest.spyOn(global.console, 'warn').mockImplementation();
+    const spy = jest.spyOn(global.console, 'warn').mockImplementation();
 
     expect(typeof formatMessage('form')).toBe('object');
-    expect(console.warn).toBeCalledWith(
+    expect(spy).toBeCalledWith(
       `[svelte-i18n] Message with id "form" must be of type "string", found: "object". Gettin its value through the "$format" method is deprecated; use the "json" method instead.`,
     );
 
-    global.console.warn = warn;
+    spy.mockRestore();
   });
 
   it('warn on missing messages', () => {
-    const { warn } = global.console;
-
-    jest.spyOn(global.console, 'warn').mockImplementation();
+    const spy = jest.spyOn(global.console, 'warn').mockImplementation();
 
     formatMessage('missing');
 
-    expect(console.warn).toBeCalledWith(
+    expect(spy).toBeCalledWith(
       `[svelte-i18n] The message "missing" was not found in "en".`,
     );
 
-    global.console.warn = warn;
+    spy.mockRestore();
+  });
+
+  it('does not throw with invalid syntax', () => {
+    $locale.set('en');
+    const spy = jest.spyOn(global.console, 'warn').mockImplementation();
+
+    // eslint-disable-next-line line-comment-position
+    formatMessage('with-syntax-error', { values: { name: 'John' } });
+
+    expect(spy).toHaveBeenCalledWith(
+      expect.stringContaining(
+        `[svelte-i18n] Message "with-syntax-error" has syntax error:`,
+      ),
+      expect.anything(),
+    );
+
+    spy.mockRestore();
   });
 });