Refactor Show.php and docker.php to improve code readability and maintainability

This commit is contained in:
Andras Bacsai 2024-04-16 12:41:33 +02:00
parent 8a8000c80a
commit faa1120e14
2 changed files with 6 additions and 3 deletions

View File

@ -50,9 +50,9 @@ public function mount()
public function checkEnvs() public function checkEnvs()
{ {
$this->isDisabled = false; $this->isDisabled = false;
if (str($this->env->key)->startsWith('SERVICE_FQDN') || str($this->env->key)->startsWith('SERVICE_URL')) { // if (str($this->env->key)->startsWith('SERVICE_FQDN') || str($this->env->key)->startsWith('SERVICE_URL')) {
$this->isDisabled = true; // $this->isDisabled = true;
} // }
if ($this->env->is_shown_once) { if ($this->env->is_shown_once) {
$this->isLocked = true; $this->isLocked = true;
} }

View File

@ -182,6 +182,9 @@ function generateServiceSpecificFqdns(ServiceApplication|Application $resource,
$environment_variables = $resource->environment_variables; $environment_variables = $resource->environment_variables;
$type = $resource->serviceType(); $type = $resource->serviceType();
} }
if (is_null($server) || is_null($type)) {
return collect([]);
}
$variables = collect($environment_variables); $variables = collect($environment_variables);
$payload = collect([]); $payload = collect([]);
switch ($type) { switch ($type) {