From dfd5cc9cefdbac6d250d07bb6e547af94f2b904f Mon Sep 17 00:00:00 2001 From: Andras Bacsai Date: Mon, 2 Sep 2024 10:57:03 +0200 Subject: [PATCH] fix: log drain only for Applications --- bootstrap/helpers/shared.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/bootstrap/helpers/shared.php b/bootstrap/helpers/shared.php index ee1ceb049..e7b42ea2c 100644 --- a/bootstrap/helpers/shared.php +++ b/bootstrap/helpers/shared.php @@ -2819,8 +2819,10 @@ function parseDockerComposeFile(Service|Application $resource, bool $isNew = fal $defaultLabels = defaultLabels($resource->id, $containerName, $pull_request_id, type: 'application'); $serviceLabels = $serviceLabels->merge($defaultLabels); - if ($server->isLogDrainEnabled() && $resource->isLogDrainEnabled()) { - data_set($service, 'logging', generate_fluentd_configuration()); + if ($server->isLogDrainEnabled()) { + if ($resource instanceof Application && $resource->isLogDrainEnabled()) { + data_set($service, 'logging', generate_fluentd_configuration()); + } } if ($serviceLabels->count() > 0) { if ($resource->settings->is_container_label_escape_enabled) { @@ -2923,8 +2925,10 @@ function newParser(Application|Service $resource, int $pull_request_id = 0, ?int $restart = data_get_str($service, 'restart', RESTART_MODE); $logging = data_get($service, 'logging'); - if ($server->isLogDrainEnabled() && $resource->isLogDrainEnabled()) { - $logging = generate_fluentd_configuration(); + if ($server->isLogDrainEnabled()) { + if ($resource instanceof Application && $resource->isLogDrainEnabled()) { + $logging = generate_fluentd_configuration(); + } } $volumes = collect(data_get($service, 'volumes', [])); $networks = collect(data_get($service, 'networks', []));